Open
Conversation
…@ check. Fixed issue with repeated random numbers Fixed an issue with UTF-8 characters in subject lines i.e £ sign Added a zero padded random integer replacement
strawp
reviewed
Feb 1, 2017
Owner
strawp
left a comment
strawp
left a comment
There was a problem hiding this comment.
Thanks!
- Why is the usedints a dict? Isn't it just a list?
- Is it the intended behaviour to have two separate random ints per email or would it be better to just pad the first random int in order to fill {randomintpadded}?
Author
|
Dictionary is being used as a lookup table. List lookups are O(n) whereas dictionary lookups are O(1) so it makes more sense speed wise to use a dictionary.
Well, I just had some images with padded integer numbers 0000blah.png so needed this. I don't think it does any harm.
I also have a fix for using google smtp which requires starttls which I will commit later
Tom
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Iain Wallace <notifications@github.com>
Sent: Wednesday, February 1, 2017 10:32:49 AM
To: strawp/random-scripts
Cc: Tom; Author
Subject: Re: [strawp/random-scripts] Various fixes (#1)
@strawp commented on this pull request.
Thanks!
1. Why is the usedints a dict? Isn't it just a list?
2. Is it the intended behaviour to have two separate random ints per email or would it be better to just pad the first random int in order to fill {randomintpadded}?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARJh6P9waUnQXiKurBqOkvLUuNHF9pBLks5rYF9RgaJpZM4Ly105>.
|
strawp
approved these changes
Feb 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue with sending mail to non-email addresses. Added noddy @ check.
Fixed issue with repeated random numbers
Fixed an issue with UTF-8 characters in subject lines i.e £ sign
Added a zero padded random integer replacement