fix: correct GitHub OAuth issuer URL for RFC 9207 compliance#182
Merged
fix: correct GitHub OAuth issuer URL for RFC 9207 compliance#182
Conversation
GitHub sends iss=https://github.com/login/oauth in OAuth authorization responses per RFC 9207. PR #180 set the wrong issuer (https://github.com), so the oauth4webapi validation continued to fail. This corrects the URL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issuerfromhttps://github.comtohttps://github.com/login/oauthinconvex/auth.tsiss=https://github.com/login/oauthin OAuth authorization responses per RFC 9207, causingoauth4webapito reject the callback when the issuer doesn't matchhttps://github.com); this PR sets the correct valueContext
GitHub rolled out RFC 9207 (Authorization Server Issuer Identification) between 2026-04-06 and 2026-04-10, adding an
issparameter to OAuth authorization responses. Theoauth4webapilibrary validates thatissmatchesas.issuerexactly. Without the correct issuer configured, all GitHub OAuth logins fail.Test plan
🤖 Generated with Claude Code