Skip to content

fix: use ConvexError in agents/integrations/memories publish mutations #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juhgiyo merged 1 commit into from
Apr 13, 2026
Merged

fix: use ConvexError in agents/integrations/memories publish mutations #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions convex/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { v } from "convex/values";
import { ConvexError, v } from "convex/values";
import { paginationOptsValidator } from "convex/server";
import { mutation, query, internalMutation } from "./_generated/server";
import { internal } from "./_generated/api";
Expand Down Expand Up @@ -334,11 +334,11 @@ export const publish = mutation({
validateAgentFiles(args.files);

const userId = await getAuthUserId(ctx);
if (!userId) throw new Error("Not authenticated");
if (!userId) throw new ConvexError("Not authenticated");

const user = await ctx.db.get(userId);
if (!user) throw new Error("User not found");
if (user.deactivatedAt) throw new Error("Account is deactivated");
if (!user) throw new ConvexError("User not found");
if (user.deactivatedAt) throw new ConvexError("Account is deactivated");

const now = Date.now();

Expand All @@ -361,10 +361,10 @@ export const publish = mutation({

if (agent) {
if (agent.ownerUserId !== user._id) {
throw new Error("You do not own this agent");
throw new ConvexError("You do not own this agent");
}
if (agent.softDeletedAt) {
throw new Error("Agent has been deleted");
throw new ConvexError("Agent has been deleted");
}
} else {
const agentId = await ctx.db.insert("agents", {
Expand Down Expand Up @@ -398,13 +398,13 @@ export const publish = mutation({
q.eq("agentId", agent!._id).eq("version", version),
)
.first();
if (existing) throw new Error(`Version ${version} already exists`);
if (existing) throw new ConvexError(`Version ${version} already exists for agent '${args.slug}'`);

// Check version is greater than latest
if (latestVer) {
if (compareVersions(parseVersion(version), parseVersion(latestVer)) <= 0) {
throw new Error(
`Version ${version} must be greater than the latest version ${latestVer}`,
throw new ConvexError(
`Version ${version} must be greater than the latest version ${latestVer} for agent '${args.slug}'`,
);
}
}
Expand Down
18 changes: 9 additions & 9 deletions convex/integrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { v } from "convex/values";
import { ConvexError, v } from "convex/values";
import { paginationOptsValidator } from "convex/server";
import { mutation, query, internalMutation } from "./_generated/server";
import { internal } from "./_generated/api";
Expand Down Expand Up @@ -331,11 +331,11 @@ export const publish = mutation({
validateIntegrationFiles(args.files);

const userId = await getAuthUserId(ctx);
if (!userId) throw new Error("Not authenticated");
if (!userId) throw new ConvexError("Not authenticated");

const user = await ctx.db.get(userId);
if (!user) throw new Error("User not found");
if (user.deactivatedAt) throw new Error("Account is deactivated");
if (!user) throw new ConvexError("User not found");
if (user.deactivatedAt) throw new ConvexError("Account is deactivated");

const now = Date.now();

Expand All @@ -356,10 +356,10 @@ export const publish = mutation({

if (integration) {
if (integration.ownerUserId !== user._id) {
throw new Error("You do not own this integration");
throw new ConvexError("You do not own this integration");
}
if (integration.softDeletedAt) {
throw new Error("Integration has been deleted");
throw new ConvexError("Integration has been deleted");
}
} else {
const integrationId = await ctx.db.insert("integrations", {
Expand Down Expand Up @@ -391,12 +391,12 @@ export const publish = mutation({
q.eq("integrationId", integration!._id).eq("version", version),
)
.first();
if (existing) throw new Error(`Version ${version} already exists`);
if (existing) throw new ConvexError(`Version ${version} already exists for integration '${args.slug}'`);

if (latestVer) {
if (compareVersions(parseVersion(version), parseVersion(latestVer)) <= 0) {
throw new Error(
`Version ${version} must be greater than the latest version ${latestVer}`,
throw new ConvexError(
`Version ${version} must be greater than the latest version ${latestVer} for integration '${args.slug}'`,
);
}
}
Expand Down
18 changes: 9 additions & 9 deletions convex/memories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { v } from "convex/values";
import { ConvexError, v } from "convex/values";
import { paginationOptsValidator } from "convex/server";
import { mutation, query, internalMutation } from "./_generated/server";
import { internal } from "./_generated/api";
Expand Down Expand Up @@ -333,11 +333,11 @@ export const publish = mutation({
validateMemoryFiles(args.files);

const userId = await getAuthUserId(ctx);
if (!userId) throw new Error("Not authenticated");
if (!userId) throw new ConvexError("Not authenticated");

const user = await ctx.db.get(userId);
if (!user) throw new Error("User not found");
if (user.deactivatedAt) throw new Error("Account is deactivated");
if (!user) throw new ConvexError("User not found");
if (user.deactivatedAt) throw new ConvexError("Account is deactivated");

const now = Date.now();

Expand All @@ -360,10 +360,10 @@ export const publish = mutation({

if (memory) {
if (memory.ownerUserId !== user._id) {
throw new Error("You do not own this memory");
throw new ConvexError("You do not own this memory");
}
if (memory.softDeletedAt) {
throw new Error("Memory has been deleted");
throw new ConvexError("Memory has been deleted");
}
} else {
const memoryId = await ctx.db.insert("memories", {
Expand Down Expand Up @@ -397,13 +397,13 @@ export const publish = mutation({
q.eq("memoryId", memory!._id).eq("version", version),
)
.first();
if (existing) throw new Error(`Version ${version} already exists`);
if (existing) throw new ConvexError(`Version ${version} already exists for memory '${args.slug}'`);

// Check version is greater than latest
if (latestVer) {
if (compareVersions(parseVersion(version), parseVersion(latestVer)) <= 0) {
throw new Error(
`Version ${version} must be greater than the latest version ${latestVer}`,
throw new ConvexError(
`Version ${version} must be greater than the latest version ${latestVer} for memory '${args.slug}'`,
);
}
}
Expand Down
Loading