fix(ui): handle null wildcard_value in formatWithTemplate#460
Open
staging-devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(ui): handle null wildcard_value in formatWithTemplate#460staging-devin-ai-integration[bot] wants to merge 1 commit into
staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The guard `wildcard !== undefined && wildcard !== null` incorrectly excluded null-valued wildcards used by RawVideo, EncodedVideo, EncodedAudio, and Custom fields. Use `'wildcard_value' in rule` instead, matching the approach already used by `canConnectPair`. Closes #443 Signed-off-by: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 65.91% 65.90% -0.01%
==========================================
Files 217 217
Lines 57496 57495 -1
Branches 1597 1597
==========================================
- Hits 37896 37892 -4
- Misses 19594 19597 +3
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #443.
formatWithTemplatehad a guardwildcard !== undefined && wildcard !== nullthat incorrectly excludednull-valued wildcards. The server registry usesnullas a valid wildcard value for RawVideo, EncodedVideo, EncodedAudio, and Custom fields. When a field's value matched the wildcard, it should display as*but was showing the literal string"null".Changed the guard to
'wildcard_value' in rule, matching the approach already used bycanConnectPairin the same file.Updated the corresponding test to expect
'Raw Video (*x*, Rgba8)'instead of the previous buggy'Raw Video (nullxnull, Rgba8)'.Review & Testing Checklist for Human
*instead of"null"in the pipeline editor UINotes
Two-line code fix + test assertion update. The
canConnectPairfunction in the same file already handled this correctly.Link to Devin session: https://staging.itsdev.in/sessions/13a4a8f5837b4c6fbfb42b2931249d3b
Requested by: @streamer45
Devin Review
0e17ec6