feat: fix fs.promises.glob return type to match Node.js API#1162
Open
feat: fix fs.promises.glob return type to match Node.js API#1162
Conversation
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Bug: fs.promises.glob incorrect return typing
feat: fix fs.promises.glob return type to match Node.js API
Aug 14, 2025
|
Dear @streamich, first of all, thank you for the memfs package. It made unit tests that operate on the filesystem in my project a lot easier to write and maintain. However, I suffer from the issue that this Pull Request is trying to fix. Before this fix, I had to mock the glob in a nasty way like: Do you have plans to review this Pull Request in the near future? |
|
Hmm, also, glob should be able to accept an array of string inputs as well, which doesn't seem to work properly at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fs.promises.globmethod in memfs was incorrectly returningPromise<string[]>instead of the Node.js standardAsyncIterableIterator<string>. This made it incompatible with the native Node.js API and prevented users from using the standardfor await...ofiteration pattern.What was wrong
What's fixed
Implementation
GlobAsyncIterator: A custom AsyncIterator implementation that yields glob results incrementallywithFileTypesand multiple patternswithFileTypesoption and multiple pattern supportThe fix ensures memfs now perfectly matches the Node.js
fs.promises.globAPI, enabling seamless migration between real and in-memory file systems.Fixes #1161.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.