[WIP][ST] Remove fixed css selectors, utilize components from PW and OUIA ids - #2805
Draft
jankalinic wants to merge 2 commits into
Draft
[WIP][ST] Remove fixed css selectors, utilize components from PW and OUIA ids#2805jankalinic wants to merge 2 commits into
jankalinic wants to merge 2 commits into
Conversation
Signed-off-by: jkalinic <jkalinic@redhat.com>
Contributor
Author
|
/systemtests run --profile=regression --install-type=olm --retry-count=2 |
Signed-off-by: jkalinic <jkalinic@redhat.com>
|
Contributor
Author
|
/systemtests run --profile=regression --install-type=olm --retry-count=2 |
❌ Systemtests run finished - failure ❌Test Summary:
Used parameters:
Test Failures:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR does following:
The changes made in this PR get rid of the long CssSelectors and it's classes, but keeps the overall logic of -> for groups page in tests - get selectors from GroupsPage..... for topics page from TopicsPage etc, so that it's clear where lies what. Adding some common constants used throughout the tests and selectors, separated OUIA constants for easier lookup.
This refactor needs followup PRs with changes touching the PwUtils, but it should work without it as well.
Assisted by: Sonnet 5