Extract fault injection points#5
Open
see-quick wants to merge 2 commits into
Open
Conversation
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
see-quick
changed the title
ppatierno
reviewed
May 17, 2026
| * @param shouldFail whether to throw | ||
| * @param exception the exception to throw | ||
| */ | ||
| static void maybeInjectFailure(boolean shouldFail, RuntimeException exception) { |
Member
There was a problem hiding this comment.
What's the case I should call this method with false so it would do nothing, instead of not calling it at all? What's the advantage of not having the caller making such decision?
Member
Author
There was a problem hiding this comment.
You mean like this?
if (config.getBoolean(...)) {
injectFailure(... ); // here exception ));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extract fault injection points into dedicated util class.