Add reminders about security best practices and redact secrets in logs #3078
Merged
cmoresco-stripe merged 8 commits intomainfrom Apr 14, 2026
Merged
Add reminders about security best practices and redact secrets in logs #3078cmoresco-stripe merged 8 commits intomainfrom
cmoresco-stripe merged 8 commits intomainfrom
Conversation
rgy-stripe
reviewed
Apr 7, 2026
Contributor
rgy-stripe
left a comment
rgy-stripe
left a comment
There was a problem hiding this comment.
just two small suggestions!
Comment on lines
+11
to
+12
| # Don't put any keys in code. Use an environment variable (as shown | ||
| # here) or secrets vault to supply keys to your integration. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Don't put any keys in code. Use an environment variable (as shown | |
| # here) or secrets vault to supply keys to your integration. | |
| # Don't put any keys in code. Use an environment variable | |
| # or secrets vault to supply keys to your integration. |
Suggesting this just to cut down on the number of words overall. But it's also fine to keep if you think it helps a user understand the connection more.
Contributor
Author
There was a problem hiding this comment.
If you don't feel strongly, I think I'd prefer to keep it--IMO it helps the user understand how it relates to the code below (e.g., if they're unfamiliar with bash they may recognize that this is environment variable syntax)
Co-authored-by: rgy-stripe <84934349+rgy-stripe@users.noreply.github.com>
Contributor
Author
|
Thank you! |
cmoresco-stripe
requested review from
ashin-stripe and
rgy-stripe
and removed request for
rgy-stripe
ashin-stripe
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.