Skip to content

Fix manual entry not working in Financial Connections#2490

Merged
torrance-stripe merged 2 commits into
masterfrom
torrance/collect-bank-account-token-for-connect
Jun 12, 2026
Merged

Fix manual entry not working in Financial Connections#2490
torrance-stripe merged 2 commits into
masterfrom
torrance/collect-bank-account-token-for-connect

Conversation

@torrance-stripe

@torrance-stripe torrance-stripe commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch the openFinancialConnections bridge in EmbeddedComponent from collectFinancialConnectionsAccounts to collectBankAccountToken, mirroring what the native iOS and Android Connect SDKs already do. This fixes manual bank-account entry in ConnectAccountOnboarding — previously, manual entry didn't return a token, so no external account was created on the connected account.
  • Add a toStripeJsBankAccountToken mapper that converts the RN SDK's camelCase BankAccountToken to the snake_case Stripe.js API shape (token.bank_account.currency, etc.) that connect-js/ARK expects.
  • Add connectedAccountId to CollectBankAccountTokenParams so the bridge call type-checks (the native layers already read this field).

Motivation

User reported a bug

Testing

  • I tested this manually
  • I added automated tests
  • Reproduced the issue locally, i.e. that manual entry didn't work on livemode
  • Afterwards, tested that manual entry + standard FC flow worked

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@torrance-stripe torrance-stripe requested review from a team as code owners June 11, 2026 17:27

@maragues-stripe maragues-stripe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@torrance-stripe torrance-stripe merged commit 9e81ade into master Jun 12, 2026
9 checks passed
@torrance-stripe torrance-stripe deleted the torrance/collect-bank-account-token-for-connect branch June 12, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants