Skip to content

Fix timestamp protection silently dropping equal-timestamp updates #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matingathani wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix timestamp protection silently dropping equal-timestamp updates #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sync-engine/src/database/postgres.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ export class PostgresClient {
.map((x) => `"${x}" = EXCLUDED."${x}"`)
.join(',')},
last_synced_at = :last_synced_at
WHERE "${table}"."last_synced_at" IS NULL
OR "${table}"."last_synced_at" < :last_synced_at;`
WHERE "${table}"."last_synced_at" IS NULL
OR "${table}"."last_synced_at" <= :last_synced_at;`
Comment on lines +202 to +203
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring example immediately above this query still shows a strict "< :last_synced_at" comparison, but the implementation now uses "<=". Please update the example so documentation matches the actual behavior.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes conflict resolution semantics for equal timestamps, but there isn't a test asserting that an event with the same created/last_synced_at as the stored row still overwrites data. Please add coverage (e.g., extend the existing "older timestamp does not override" webhook test to include a same-timestamp update that should override).

Suggested change
OR "${table}"."last_synced_at" <= :last_synced_at;`
OR "${table}"."last_synced_at" < :last_synced_at;`

Copilot uses AI. Check for mistakes.
}

/**
Expand Down
Loading