Open
Conversation
- Added option to save to origin folder - Made options persistent - If file is dropped on icon while that app is not already open, app quits after process is complete - Moved warnings and errors to a tableview instead of an alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Known Issues
Notes
Some of the code is refactored by the nature of moving the Unretiner methods into the singleton class. This was necessary because the methods that handle file drops on the app icon are finished before the UnretinaViewController is instantiated. Other than that, I attempted to keep the same structure and style.
There was a method in AppDelegate.m called
- (void)appication:(NSApplication*)sender openFile:(NSString*)filethat I don't think was actually doing anything. I've corrected the naming and pointed it to the openFiles variant of the same method. (I'm more familiar with iOS than OSX development, so I'm not sure if keeping it is even necessary as the app was functioning as expected without it.)