fix: correct unique_id generation for KegSensor and KegOnlineStatusSensor#10
Open
fix: correct unique_id generation for KegSensor and KegOnlineStatusSensor#10
Conversation
Contributor
Preview Release CreatedA preview release has been created for testing this PR. Version: How to Test
Or install directly via HACS:WARNING: This is a preview release - do not use in production! Once testing is complete and approved, this PR can be merged for an official release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes small improvements to the
KegSensorclass incustom_components/minibrew/sensor.pyto ensure consistent use of the device identifier and simplify the generation of unique IDs.Most important changes:
Device identifier consistency:
__init__method now setsself.deviceto the passeddeviceobject, ensuring it is available throughout the class.Unique ID generation:
unique_idproperty now consistently usesself.device_idinstead of directly accessingself.device.serial_number, simplifying the code and reducing redundancy. [1] [2]Closes #9