feat: add serial number to device info for Craft and Keg sensors#11
Merged
feat: add serial number to device info for Craft and Keg sensors#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to the
CraftSensorclass in thecustom_components/minibrew/sensor.pyfile by ensuring that the device instance is stored and the device's serial number is included in the sensor's device information.deviceinstance is now explicitly stored as an attribute of theCraftSensorclass, which can help with future access or debugging.serial_numberis now included in the_attr_device_infodictionary for both "Craft" and "Smart Keg" models, improving device identification in Home Assistant. [1] [2]