Fix Windows-breaking workflowsPath + version drift + coverage (45->49)#1
Merged
Merged
Conversation
…version sync
All five worker.ts files resolved workflowsPath via
`new URL("./workflows.js", import.meta.url).pathname`. On Windows
URL.pathname returns a drive-prefixed path (`/C:/...`) that is not a
valid filesystem path, so Worker.create() cannot find the workflow
bundle and the worker fails to boot. Switched to
`fileURLToPath(new URL(...))` — the same ESM-correct helper the test
files already use and that the v0.1.0 anti-patterns section documents.
Forks on Windows now boot.
Coverage:
- HostedMemoryClient: tested the per-request timeout/AbortController path
(hung backend aborts after timeoutMs → status-less MemoryClientError =
retryable at the activity layer, original AbortError preserved on
`cause`), plus decide() HTTP success + missing-id paths and baseUrl
trailing-slash normalization. Adapter suite 16 -> 20.
- T03 saga: the all-compensations-succeed rollback path now asserts the
persisted mistake learning takes the "All compensations succeeded"
branch and does NOT carry the `compensation-failure` tag.
Version consistency: every workspace package.json was 0.0.1 while the
README badge said v0.1.0 and the CI comment said v0.1.1. Aligned all
seven packages + lockfile + README + CI + CHANGELOG to 0.1.1.
Determinism audit: all five workflow files are clean (no
Date.now/Math.random/IO in workflow code; T04 correctly captures
wall-clock via a captureRunAt activity). No determinism fixes needed.
Build green, 49/49 tests pass (was 45/45), npm ci consistent.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Template-correctness + fork DX. (Determinism audited clean against the current Temporal TS SDK via context7 — genuinely solid repo.) Built against public HEAD 4604293.
worker.tsusednew URL(...).pathnameforworkflowsPath, which yields/C:/...on Windows (invalid path -> worker will not boot). Switched tofileURLToPath(matching what the tests already use).0.0.1while README said v0.1.0 and CI v0.1.1 — aligned to 0.1.1 + CHANGELOG.Tests 45 -> 49. Version 0.0.1 -> 0.1.1 (resolves drift). No publish in this PR.