This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Create backups of all patterns in case a theme update wipes them out#101
Open
johnstonphilip wants to merge 1 commit intomainfrom
Open
Create backups of all patterns in case a theme update wipes them out#101johnstonphilip wants to merge 1 commit intomainfrom
johnstonphilip wants to merge 1 commit intomainfrom
Conversation
kienstra
reviewed
Mar 8, 2023
Contributor
There was a problem hiding this comment.
Hi @johnstonphilip,
Good response to feedback, but having 2 sources of truth isn't great.
Update: Not really 2 sources of truth, as 1 is only a backup.
If a theme update wipes out the patterns, maybe they're not the ideal user.
They're probably not using GIT, which might defeat the purpose of PM.
Contributor
Author
|
Another idea: search for a |
Contributor
|
Interesting, I like that more |
Contributor
Author
|
Another possible replacement for this in #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just in case we have a user who uses this in production without understanding the dangers, we can create backups of the generated pattern files for them, which they can use to recover any pattern files they wiped out out by updating their theme.
How to test
/wp-content/pattern-backups/the-theme-name/Suggested changelog entry