-
Notifications
You must be signed in to change notification settings - Fork 339
Fixed #1123 Add missing Returns section in docstrings #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1124 |
|
@NimaSarajpoor I don't think I've covered all Please review at your earliest convenience. |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlaw
Thanks for the PR!! I left two comments. Not relevant directly to this PR but they are related to docstring.py.
NimaSarajpoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlaw
I checked other changed files, and left a few comments to bring your attention to the docstrings that have out1 or out2 as the output variable name (and not out).
|
@NimaSarajpoor I think we might be good now? |
@seanlaw Nothing stands out to me! I think it is ready to be merged. Thanks for the fix!! |
See #1123
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory