Handle missing dist in CLI bin#44
Open
xianzuyang9-blip wants to merge 2 commits into
Open
Conversation
Code Review by Qodo
1.
|
Review Summary by QodoHandle missing dist in CLI bin with recovery hint
WalkthroughsDescription• Catch startup failures when dist/cli.js missing • Print recovery hint directing users to run npm run build • Add regression test for missing dist scenario Diagramflowchart LR
bin["bin/excod.cjs"] -->|import dist/cli.js| catch["catch error handler"]
catch -->|missing dist| error["print recovery hint"]
error -->|exit 1| process["process exit"]
test["tests/bin.test.ts"] -->|verify| behavior["error behavior"]
File Changes1. bin/excod.cjs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/excod.cjswhendist/cli.jshas not been builtnpm run buildFixes #6.
Validation
npm testnpm run buildnpm run lintdist/, runnode bin/excod.cjs, confirm it exits 1 with the build hint