[C#] Bump syntax version, fix pop: true & order#4412
Closed
jrappen wants to merge 1 commit intosublimehq:masterfrom
Closed
[C#] Bump syntax version, fix pop: true & order#4412jrappen wants to merge 1 commit intosublimehq:masterfrom
pop: true & order#4412jrappen wants to merge 1 commit intosublimehq:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
jrappen
force-pushed
the
fix-csharp
branch
3 times, most recently
from
8bac9fc to
e6e572c
Compare
Collaborator
Author
|
Still have to address changes due to https://www.sublimetext.com/docs/syntax.html#compatibility. |
Collaborator
|
Do you want to drop to version 1, merge, and work on v2 later? |
Collaborator
Author
|
Whatever works for you guys, I'm kinda busy irl. |
This commit: - bumps the syntax to version 2 - replaces `pop: true` with `pop: 1` - adds section markers - changes order of contexts where contexts were not in their section
Collaborator
Author
|
I fixed a few, Michael. I'll try to do the left overs tonight. |
deathaxe
reviewed
Jan 17, 2026
| /// ^^^^^^^^ meta.class.record | ||
| /// ^^^^^^^^^ meta.class.constructor.parameters | ||
| /// ^ - meta.class | ||
| /// ^ meta.class.record.body punctuation.terminator.statement |
Collaborator
There was a problem hiding this comment.
Well, modifying test cases doesn't mean fixing issues. Note that trailing semicolon most likely does not belong to meta.class (especially not meta.class.record.body) and thus syntax needs to be adjusted for the old test to succeed.
Collaborator
Author
|
closing, (partially) superseded by #4496 |
jrappen
pushed a commit
that referenced
this pull request
Apr 4, 2026
This PR moves some contexts around and adds section headers without changing any behavior. It is a first step towards some refactoring with the goal to apply some more modern structure best practices and split syntax definition into sections for hopefully better overview about which parts belong together. The idea is to do this in small reviewable steps, instead of a big rewrite, which may land not anytime soon. It partly supersedes #4412, but with defering breaking changes like version 2 syntax to future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit:
pop: truewithpop: 1else-pop(prototype) context