adding tabindex to logo and search field#72
Open
jamiewilson wants to merge 1 commit intosublimehq:masterfrom
jamiewilson:master
Open
adding tabindex to logo and search field#72jamiewilson wants to merge 1 commit intosublimehq:masterfrom jamiewilson:master
jamiewilson wants to merge 1 commit intosublimehq:masterfrom
jamiewilson:master
Conversation
Member
|
Thanks for taking the time to suggest from improvements! The opacity transition is currently being used (https://github.com/wbond/packagecontrol.io/blob/master/app/css/package.scss#L7-L13). Try navigating from a package detail page to the homepage. Also try hovering over the logo on a package detail page. Setting the tab index should be good. Generally I'm not a huge fan of overriding the |
Author
|
Cool. Thanks for pointing that out. Somehow I missed that opacity usage! I just removed the styling, so feel free to merge this for the tabindex additions, but if it's easier to add them yourself, no worries. Just one of those things I always find myself doing when I come to search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First tab to search, second tab to logo/home link, third to next anchor, currently first link in the nav