Conversation
Contributor
|
preview environment is ready at https://243-25d3ee6.multisig-preview.subscan.io |
There was a problem hiding this comment.
Pull request overview
This PR targets multisig “loading/refresh” behavior (ref. subscan-explorer/subscan#5152) by restructuring multisig data fetching and adding an extrinsic update callback to refresh in-progress data after submissions.
Changes:
- Trigger in-progress multisig record fetching from the provider layer and adjust multisig hooks to expose loading state.
- Fix stale-hook closures by adding proper
useCallbackdependencies and by selecting Subscan/Subquery fetch functions explicitly. - Add an
onTxUpdatecallback path fromWalletState→ExtrinsicLaunch→TxButtonMultisigto refresh in-progress records while tx progresses.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/providers/multisig-provider.tsx | Triggers fetchInProgress() on mount via provider to kick off multisig record loading. |
| src/hooks/subscan.ts | Updates Subscan hook callbacks to depend on network and sets multisig detail to null on error. |
| src/hooks/multisig.ts | Removes implicit auto-fetch and exposes loading state from useMultisigRecords. |
| src/hooks/combineQuery.ts | Refactors data-source selection logic and updates types for multisigAccount nullable handling. |
| src/components/WalletState.tsx | Adds onTxUpdate handler to refresh in-progress records after tx updates. |
| src/components/ExtrinsicRecords.tsx | Alters fetching effects for confirmed/cancelled tabs/pagination (currently disables them). |
| src/components/ExtrinsicLaunch.tsx | Adds onTxUpdate prop passthrough (but onTxFail is still not forwarded). |
| src/components/Entries.tsx | Shows a spinner instead of “-” when call data is empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
preview environment is ready at https://243-308812f.multisig-preview.subscan.io |
freehere107
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/subscan-explorer/subscan/issues/5152