Revive repo: CI, Tests and type system (partial) (closes #3)

.editorconfig

@@ -0,0 +1,15 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.cs]
+charset = utf-8-bom
+indent_style = space
+indent_size = 2
+
+[*.{csproj,props,targets,slnx,json,yml,yaml}]
+indent_style = space
+indent_size = 2

.gitattributes

@@ -0,0 +1,2 @@
+* text=auto eol=lf
+*.png binary

.github/workflows/ci.yml

@@ -0,0 +1,39 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build-and-test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
+        with:
+          submodules: recursive
+
+      - uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9 # v4
+        with:
+          dotnet-version: "10.0.x"
+
+      - name: Restore
+        run: dotnet restore substrait-csharp.slnx
+
+      - name: Check code style
+        run: dotnet format substrait-csharp.slnx --verify-no-changes
+
+      - name: Build
+        run: dotnet build substrait-csharp.slnx --no-restore --configuration Release
+
+      - name: Test
+        run: dotnet test substrait-csharp.slnx --no-build --configuration Release

Directory.Build.props

@@ -0,0 +1,6 @@
+<Project>
+  <PropertyGroup>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <AnalysisLevel>latest-recommended</AnalysisLevel>
+  </PropertyGroup>
+</Project>

global.json

@@ -0,0 +1,6 @@
+{
+  "sdk": {
+    "version": "10.0.100",
+    "rollForward": "latestMinor"
+  }
+}

src/Substrait.Core/Relation/Aggregate.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The AGGREGATE relational operator representing GROUP BY semantics, <see cref="Protobuf.AggregateRel"/>
+/// </summary>
+public class Aggregate : Rel
 {
-  /// <summary>
-  /// The AGGREGATE relational operator representing GROUP BY semantics, <see cref="Protobuf.AggregateRel"/>
-  /// </summary>
-  public class Aggregate : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Fetch.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The FETCH relational operator representing LIMIT or TOP semantics, <see cref="Protobuf.FetchRel"/>
+/// </summary>
+public class Fetch : Rel
 {
-  /// <summary>
-  /// The FETCH relational operator representing LIMIT or TOP semantics, <see cref="Protobuf.FetchRel"/>
-  /// </summary>
-  public class Fetch : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Filter.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The FILTER relational operator, <see cref="Protobuf.FilterRel"/>
+/// </summary>
+public class Filter : Rel
 {
-  /// <summary>
-  /// The FILTER relational operator, <see cref="Protobuf.FilterRel"/>
-  /// </summary>
-  public class Filter : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Join.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The binary JOIN relational operator, <see cref="Protobuf.JoinRel"/>
+/// </summary>
+public class Join : Rel
 {
-  /// <summary>
-  /// The binary JOIN relational operator, <see cref="Protobuf.JoinRel"/>
-  /// </summary>
-  public class Join : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Project.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The PROJECT relational operator representing calculated expressions of fields, <see cref="Protobuf.ProjectRel"/>
+/// </summary>
+public class Project : Rel
 {
-  /// <summary>
-  /// The PROJECT relational operator representing calculated expressions of fields, <see cref="Protobuf.ProjectRel"/>
-  /// </summary>
-  public class Project : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Read.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The READ relational operator representing data scan, <see cref="Protobuf.ReadRel"/>
+/// </summary>
+public class Read : Rel
 {
-  /// <summary>
-  /// The READ relational operator representing data scan, <see cref="Protobuf.ReadRel"/>
-  /// </summary>
-  public class Read : Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Rel.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// Base type for all relational operators, <see cref="Protobuf.Rel"/>
+/// </summary>
+public abstract class Rel
 {
-  /// <summary>
-  /// Base type for all relational operators, <see cref="Protobuf.Rel"/>
-  /// </summary>
-  abstract public class Rel
-  {
-  }
 }

src/Substrait.Core/Relation/Sort.cs

@@ -1,9 +1,8 @@
-namespace Substrait.Relation
+namespace Substrait.Core.Relation;
+
+/// <summary>
+/// The SORT relational operator representing ORDER BY semantics, <see cref="Protobuf.SortRel"/>
+/// </summary>
+public class Sort : Rel
 {
-  /// <summary>
-  /// The SORT relational operator representing ORDER BY semantics, <see cref="Protobuf.SortRel"/>
-  /// </summary>
-  public class Sort : Rel
-  {
-  }
 }

src/Substrait.Core/Substrait.Core.csproj

@@ -1,20 +1,20 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <ProtoBufNet_Debug>True</ProtoBufNet_Debug>
   </PropertyGroup>
 
   <ItemGroup>
-    <Protobuf Include="../../substrait/proto/substrait/**/*.proto" ProtoRoot="../../substrait/proto/" CompileOutputs="false" OutputDir="generated/proto/" GrpcServices="None" />
+    <Protobuf Include="../../substrait/proto/substrait/**/*.proto" ProtoRoot="../../substrait/proto/" CompileOutputs="true" OutputDir="generated/proto/" GrpcServices="None" />
   </ItemGroup>
 
 
   <ItemGroup>
-    <PackageReference Include="Google.Protobuf" Version="3.21.10" />
-    <PackageReference Include="Grpc.Tools" Version="2.50.0">
+    <PackageReference Include="Google.Protobuf" Version="3.35.1" />
+    <PackageReference Include="Grpc.Tools" Version="2.83.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>