Skip to content

feat(isthmus): configurable fallback to dynamic function mapping#647

Draft
ZorinAnton wants to merge 2 commits intosubstrait-io:mainfrom
ZorinAnton:fallback-to-dynamic-function-mappings
Draft

feat(isthmus): configurable fallback to dynamic function mapping#647
ZorinAnton wants to merge 2 commits intosubstrait-io:mainfrom
ZorinAnton:fallback-to-dynamic-function-mappings

Conversation

@ZorinAnton
Copy link
Contributor

This PR introduces a new autoFallbackToDynamicFunctionMapping feature flag that enables automatic support for all unmapped extension functions (scalar, aggregate, and window functions) in SQL↔Substrait conversions.

Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a PR (#649) to try and make wiring in what you're doing here easier. We're starting to run into the limits of the existing design of the function conversion system, and I'm wary of adding more complexity before cleaning it up.

My big issue is with how we're using the feature flags for this, because we're embedding a ton of conditional configuration logic into constructors all over the codebase, which makes it very difficult to reason about an already difficult part of the system. What I would like to do is separate out the configuration from the constructors. Effectively, can we construct all the function converters we need outside of the SubstraitRelNode and SubstraitRelVisitor, and then inject them in.

@ZorinAnton ZorinAnton force-pushed the fallback-to-dynamic-function-mappings branch from ffb5724 to df143b3 Compare March 5, 2026 16:06
@ZorinAnton ZorinAnton force-pushed the fallback-to-dynamic-function-mappings branch from df143b3 to 9314af1 Compare March 5, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants