Skip to content

feat(extensions)!: deprecate subtract(precision_timestamp_tz, interval_year) overload - #1160

Merged
nielspardon merged 2 commits into
substrait-io:mainfrom
jagjitkaur0000:fix-1153-interval-year
Aug 7, 2026
Merged

feat(extensions)!: deprecate subtract(precision_timestamp_tz, interval_year) overload#1160
nielspardon merged 2 commits into
substrait-io:mainfrom
jagjitkaur0000:fix-1153-interval-year

Conversation

@jagjitkaur0000

@jagjitkaur0000 jagjitkaur0000 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR deprecates the subtract(timestamp_tz, interval_year) overload.

Changes

  • Marked the subtract(timestamp_tz, interval_year) overload as deprecated.
  • Added deprecation metadata with version 0.100.0.
  • Added guidance to use the three-argument overload with an explicit timezone instead.

Related Issue

Fixes #1153


This change is Reviewable

@CLAassistant

CLAassistant commented Aug 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread extensions/functions_datetime.yaml Outdated
Co-authored-by: Niels Pardon <mail@niels-pardon.de>
@jagjitkaur0000

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I've updated the deprecation version to 0.100.0 as suggested.

@nielspardon nielspardon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielspardon nielspardon changed the title fix: deprecate subtract(timestamp_tz, interval_year) overload feat(extensions)!: deprecate subtract(precision_timestamp_tz, interval_year) overload Aug 7, 2026
@nielspardon
nielspardon merged commit 993ad15 into substrait-io:main Aug 7, 2026
15 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent arity for add/subtract of interval_year with precision_timestamp_tz

4 participants