fix: migrate ESLint to flat config and resolve no-unused-vars errors#530
Open
fix: migrate ESLint to flat config and resolve no-unused-vars errors#530
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-YAML-15765520
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-YAML-15765520
…into thinx-staging * 'thinx-staging' of github.com:suculent/thinx-device-api: (64 commits) feat: add commit message normalizer with prepare-commit-msg hook fix(base): updated components fix(git): test run issue regarding global key fix: move profile handler functions into module closure to fix this.user runtime crash audit: add missing logging to routes and database module chore: add commitlint config to enforce conventional commit format feat: add metrics instrumentation coverage analyzer Update console submodule for device list fix version bump http rollback for couch fix: package.json to reduce vulnerabilities added global GIT_KEY_PASSPHRASE fix: remediate 6 security anti-patterns found by foot-gun analysis fix: correct 5 bugs identified in bug-finder analysis fix: remove OAuth access_token debug log leak in router.google.js fix: correct 5 bugs identified in bug-finder analysis docs: add release notes for thinx-staging planned improvements docs: add prioritized improvements backlog fix: resolve ESLint no-unused-vars and no-extra-semi errors ... # Conflicts: # .circleci/config.yml
…aging * commit '8f5de37672867f10e561935580c010a5960008b7': fix: package.json to reduce vulnerabilities fix: package.json to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789767 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789769 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789771 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789773
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789767 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789769 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789771 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-15789773
…API spec availability)
…aging * commit '61c2130066ffd405e634df470eff79fcc16447cf': fix: package.json to reduce vulnerabilities fix: package.json to reduce vulnerabilities
- Replace .eslintrc.js + .eslintignore with eslint.config.js (flat config) - Add caughtErrorsIgnorePattern to no-unused-vars rule for ESLint v10 - Exclude submodule directories from linting scope - Prefix unused catch variables with _ across 21 source files - Prefix unused declared vars in conf/.sample_transformer.js and scripts/ - Remove stale eslint-disable directives in router.gdpr.js and worker.js - Update npm lint script: drop --config and --ignore-path flags Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslintrc.jsformat to flat configeslint.config.js(required for ESLint v10 which dropped the old format).eslintignore(replaced byignoresarray in flat config)caughtErrorsIgnorePattern: "^_"tono-unused-varsrule (ESLint v9+ now checks catch-clause variables by default)ignoresso external repos are not linted_across 21 source files to satisfy the^_pattern ruleeslint-disabledirectives that were no longer needednpm run lintscript: removed unsupported--configand--ignore-pathflags (flat config is auto-detected)Test plan
npm run lint— should exit with zero errors and zero warnings🤖 Generated with Claude Code
Nightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
Automated by nightshift