fix(core): invalid model error handling#132
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Dec 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes error handling for invalid model responses from opencode 1.0 and adds comprehensive test coverage for the user_message_count state management in the send_message function.
Key Changes:
- Refactored
user_message_counttracking logic into a reusable helper function with proper bounds checking - Fixed bug where
user_message_countwas not decremented in error handling path - Added explicit validation and error notification for invalid API responses
- Added two new unit tests verifying correct increment/decrement behavior in both success and error scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lua/opencode/core.lua | Refactored message count tracking into a helper function, added error handling for invalid responses, and fixed missing count decrement in catch block |
| tests/unit/core_spec.lua | Added two comprehensive tests verifying user_message_count is correctly incremented/decremented in both successful and error cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It looks like there was a change in opencode 1.0 that changed how invalid model errors are surfaced so this change fixes that. Also add unit test coverage for send_message changing state.user_message_count (and fix a bug with it not being updated in the catch) Hopefully fixes sudo-tee#131
cameronr
force-pushed
the
fix/invalid-model-new-session-error
branch
from
743ce9d to
7f4b114
Compare
Owner
|
Thanks for looking into this This looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there was a change in opencode 1.0 that changed how invalid model errors are surfaced so this change fixes that.
Also add unit test coverage for send_message changing state.user_message_count (and fix a bug with it not being updated in the catch)
Hopefully fixes #131