fix(ui): restore window settings when using position=current#175
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Jan 12, 2026
Merged
fix(ui): restore window settings when using position=current#175sudo-tee merged 1 commit intosudo-tee:mainfrom
sudo-tee merged 1 commit intosudo-tee:mainfrom
Conversation
Owner
|
Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
position = 'current'configuration, opencode modifies window options (wrap, number, relativenumber, signcolumn, etc.) on the current window. This PR ensures those settings are saved before modification and restored when opencode is closed.Problem
Previously, when closing opencode with
position = 'current', the window would retain opencode's settings (e.g.,wrap=true,number=false) instead of reverting to the user's original settings.Solution
position = 'current')state.saved_window_optionsFiles Changed
lua/opencode/state.lua- Addedsaved_window_optionsfield to statelua/opencode/ui/output_window.lua- Helper functionset_win_option()that saves original values before settinglua/opencode/ui/ui.lua- Restore saved options inclose_windows()