fix: defer input window keymaps to blink.cmp when visible#184
Merged
sudo-tee merged 6 commits intosudo-tee:mainfrom Jan 15, 2026
Merged
fix: defer input window keymaps to blink.cmp when visible#184sudo-tee merged 6 commits intosudo-tee:mainfrom
sudo-tee merged 6 commits intosudo-tee:mainfrom
Conversation
When blink.cmp completion menu is open, input window keymaps now defer to blink instead of taking precedence. Fixes sudo-tee#183.
…essing - replace blink checks with completion checks to enhance functionality - add new `is_visible` methods to completion engines for consistent API - updates on keymap entry processing to use new completion checks - refactor related function names for clarity and alignment with new logic
- remove unnecessary return after showing the input window - streamlines the focus_input function by reducing early exits
- improve logic to check if the current buffer is the opencode input - ensure engines remain enabled when the input window is toggled - updates(input_window): set filetype for input buffer to 'opencode'
Owner
|
This seems reasonable. Thanks for the PR |
aweis89
added a commit
to aweis89/opencode.nvim
that referenced
this pull request
Jan 29, 2026
* fix: defer input window keymaps to blink.cmp when visible When blink.cmp completion menu is open, input window keymaps now defer to blink instead of taking precedence. Fixes sudo-tee#183. * feat(keymap): integrate completion visibility checks into keymap processing - replace blink checks with completion checks to enhance functionality - add new `is_visible` methods to completion engines for consistent API - updates on keymap entry processing to use new completion checks - refactor related function names for clarity and alignment with new logic * feat(ui): enhance input window with keymap setup logic * fix(ui): improve input window focus logic - remove unnecessary return after showing the input window - streamlines the focus_input function by reducing early exits * fix(completion): enhance availability check for completion engine - improve logic to check if the current buffer is the opencode input - ensure engines remain enabled when the input window is toggled - updates(input_window): set filetype for input buffer to 'opencode' --------- Co-authored-by: Francis Belanger <francis.belanger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary