Skip to content

fix(context): deduplicate selection ranges #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudo-tee merged 1 commit into from
Feb 2, 2026
Merged

fix(context): deduplicate selection ranges #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lua/opencode/context/chat_context.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ function M.add_selection(selection)
M.context.selections = {}
end

-- prevent duplicate selection (same exact line range) from being added
for _, sel in ipairs(M.context.selections) do
if sel.file.path == selection.file.path and sel.lines == selection.lines then
return
end
end

table.insert(M.context.selections, selection)
state.context_updated_at = vim.uv.now()
end
Expand Down
36 changes: 36 additions & 0 deletions tests/unit/context_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,42 @@ describe('add_file/add_selection/add_subagent', function()
context.add_selection({ foo = 'bar' })
assert.same({ { foo = 'bar' } }, context.get_context().selections)
end)
it('does not add duplicate selections with same range', function()
local selection1 = { file = { path = '/tmp/foo.lua' }, lines = '1-2', content = 'one' }
local selection2 = { file = { path = '/tmp/foo.lua' }, lines = '1-2', content = 'two' }

context.add_selection(selection1)
context.add_selection(selection2)

assert.same({ selection1 }, context.get_context().selections)
end)
it('allows non-overlapping selections in same file', function()
local selection1 = { file = { path = '/tmp/foo.lua' }, lines = '1-2', content = 'one' }
local selection2 = { file = { path = '/tmp/foo.lua' }, lines = '4-6', content = 'two' }

context.add_selection(selection1)
context.add_selection(selection2)

assert.same({ selection1, selection2 }, context.get_context().selections)
end)
it('allows overlapping selections in same file', function()
local selection1 = { file = { path = '/tmp/foo.lua' }, lines = '1-4', content = 'one' }
local selection2 = { file = { path = '/tmp/foo.lua' }, lines = '3-6', content = 'two' }

context.add_selection(selection1)
context.add_selection(selection2)

assert.same({ selection1, selection2 }, context.get_context().selections)
end)
it('allows same line range in different files', function()
local selection1 = { file = { path = '/tmp/foo.lua' }, lines = '1-2', content = 'one' }
local selection2 = { file = { path = '/tmp/bar.lua' }, lines = '1-2', content = 'two' }

context.add_selection(selection1)
context.add_selection(selection2)

assert.same({ selection1, selection2 }, context.get_context().selections)
end)
it('adds a subagent', function()
context.add_subagent('agentX')
assert.same({ 'agentX' }, context.get_context().mentioned_subagents)
Expand Down