Conversation
|
Thanks for the PR I am a bit hesitant on this because there is also similar use case like I would prefer adding the necessary options/hooks so you could implement this in your config. There is already the option What about simply having a path_mapping option that is a function so you could do your translation logic ? This would over both wsl and docker use case instead ? I am open for ideas but I don't want to hardcode to many workflows in the plugin as I will have to maintain them without having access to the specifics setup to test them properly |
aac4c42 to
e325406
Compare
|
Yep you are right, its a very strict lock on one workflow. The |
|
Thanks for the changes you did on this, I like it better this way I think there is an overlap with another proposed MR #295 I think it's best to wait on this one to apply what is missing as there is also a Or may be you can collaborate with the author of the other MR so we can have a solution that works for both. What do you think ? |
Fail fast on invalid runtime.connection, remote_url, command arrays, timeout, and path transform returns so misconfiguration is surfaced clearly. Also URL-encode query parameters to avoid malformed API requests with mapped paths.
ff75f4d to
4db0dd3
Compare
|
Just added a remote_url option and a pre_start_command option to fully support containers / remote server. |
|
The other MR has been merged, it should cover most of what is done in this MR. If there is missing peices don;t hesitate to create another MR to add it. Let me know if you are ok with closing the PR Thanks again for your effort |
|
Hey, I checked the merged MR.
So its working for me now and I wont add something to it I guess. Probably switching opencode to pwsh in the near future, as windows support gets better and better. Thanks for you great effort and glad the path conversion could help for the MR. This can be closed of course. :) |
|
Thanks for confirming. Glad you have a working setup for your workflow. |
Request
As a windows user, that runs opencode in WSL as recommended, this plugin should start the server in wsl in the mounted path.
Implementation
Adds a
use_wslconfig.When
use_wslis set and nvim runs in windows it starts a server in wsl in the mounted path and connects.All paths are translated from unix to windows and vice verca, when running from windows with
use_wsl.Additionally in an extra commit default descriptions for the whole keymap where added - for WhichKey users etc.
But this can/could be ignored for the focus of the PR.