[pull] main from apache:main#185
Merged
Merged
Conversation
…) (#830) Phase 1: enable the dark mode mechanism and apply it to the app shell. - tailwind.config.js: change darkMode from invalid 'false' to 'class' - Add useTheme hook: respects system preference via prefers-color-scheme, allows manual override, persists choice to localStorage, reacts to OS changes - Add ThemeToggle component (sun/moon button) replacing the previously broken radio - Apply dark: variants to the app shell: container, desktop + mobile sidebar, nav links, disclosure menus, breadcrumb, and project list table - Mount theme initialization at App root to apply the dark class on load Light mode is unchanged (all changes are additive dark: variants). Remaining per-view component coverage will follow in subsequent PRs. Co-authored-by: vaquarkhan <vaquarkhan@users.noreply.github.com>
The stale-assignment workflow measured inactivity from issue.updated_at. That field is bumped by *any* change to the issue, including the bot's own warning comment and label edits. Each weekly warn therefore reset the clock, capping daysSinceUpdate at the warn interval so the 21-day unassign branch was never reached: the bot warned forever and never removed an assignee. Observed on #400: warnings at 17 then exactly 14 days later 14, again 16 then 20 days, while the assignee was never unassigned. Compute inactivity from the most recent of: last non-bot comment, the assignment event for a current assignee (so a freshly assigned issue is not instantly stale), and issue creation time. Bot comments no longer pollute the signal, so the clock accumulates and the unassign threshold is reachable. Reuse the paginated comments for the recent-warn spam guard. Signed-off-by: André Ahlert <andre@aex.partners>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )