Harden parent credential update path and enforce token TTL cap#8
Open
stjiao14 wants to merge 7 commits into
Open
Harden parent credential update path and enforce token TTL cap#8stjiao14 wants to merge 7 commits into
stjiao14 wants to merge 7 commits into
Conversation
storage: route List by prefix in SplitProvider and update tests
…orkspace/drift Harden parent credential update path and enforce token TTL cap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforced a hard maximum bearer-token TTL (24h) in internal/token/issue.go via TokenMaxTTL.
Added validation coverage for overlong TTL in internal/token/token_test.go.
Removed CLI --secret-key usage from parent-credential update commands to reduce argv leakage risk.
Updated drift parent set to source secret from DRIFT_SECRET_ACCESS_KEY or a hidden interactive prompt.
Updated hidden compatibility command drift config set-parent to reuse Workspace.ParentSet with live verification, instead of writing parent creds directly.
Updated grant flag help text to reflect enforced TTL max.