✨(frontend) make dropdown menu and language picker accessible#117
Open
✨(frontend) make dropdown menu and language picker accessible#117
Conversation
2802e59 to
045f4ae
Compare
AntoLC
reviewed
Oct 1, 2025
Contributor
There was a problem hiding this comment.
I think I let the hand @PanchoutNathan for this one, seems a "big" refacto on a important component, I don't feel totally safe to review it without testcase.
Collaborator
Author
Of course, I will be glad to talk about it @PanchoutNathan if you need it ! |
2a73b07 to
dae5c69
Compare
replace dropdownmenu div with MenuTrigger to improve accessibility Signed-off-by: Cyril <c.gromoff@gmail.com>
dae5c69 to
a176aca
Compare
Signed-off-by: Cyril <c.gromoff@gmail.com>
a176aca to
1a97777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility and usability of the dropdown menu and the language picker while keeping a fully custom trigger (no MenuTrigger), in order to maintain visual flexibility and design consistency.
issue : 1428 / lang : 898
Proposal
Improve keyboard interaction support (Enter, Space, ArrowDown) to open the menu.
Update menu items to use visible labels only (no aria-label), and apply the lang attribute directly on the text span to ensure correct pronunciation for each language.
Remove redundant or conflicting accessibility attributes (e.g. aria-label overriding visible text).
Maintain compatibility with the custom LanguagePicker, which now reuses this accessible DropdownMenu component.
Before → announced as
"Select language, bouton"
(generic button, no indication of menu or submenu)
After → announced as
"cliquable Français arrow down drop boutton , bouton de menu, réduit sous menu
(explicitly identified as a menu button with submenu, including current language labe