♿️(frontend) improve dropdown menu focus and semantics#159
Open
♿️(frontend) improve dropdown menu focus and semantics#159
Conversation
avoid dialog role for menus to fix screen reader announcements
Ovgodd
force-pushed
the
fix/access-dropdown-focus-and-role
branch
from
d4e14b1 to
a725b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove incorrect dialog semantics from dropdown menus to improve screen reader announcements and align with menu accessibility patterns.
Proposal
isNonModalonPopoverwithinDropdownMenuto preventrole="dialog"injection.Menu(role="menu") and first-item focus behavior on open.Popoverusesrole="dialog"by default, which is not appropriate for dropdown menus.