test: re-run the CodeQL suppression experiment with documented placement - #82
Merged
Merged
Conversation
EXPERIMENT, not a conclusion. PR #80 concluded that inline CodeQL suppressions are not honoured in this repository. That conclusion is unsupported: the run at 0017b3f placed the annotation as a TRAILING same-line comment, while CodeQL's documented Python suppression syntax requires a standalone comment line before the alert. One placement was tested and the result generalised to all placements. This tests the documented form. If CodeQL is green, the mechanism works, #80's call-site documentation and changelog are wrong and need correcting, and the Path.chmod call-shape dependency can be dropped for the honest os.chmod plus a stated suppression. If CodeQL is red, the negative result finally has the evidence #80 claimed, and this reverts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27b697aa1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR #80 concluded that inline suppressions are not honoured here, but the run behind it (0017b3f) used a TRAILING same-line comment, while CodeQL's documented Python syntax is a standalone comment line before the alert. One placement was tested and generalised to all -- caught by cross-family review of the learning entry that recorded the conclusion. This branch ran the documented placement (27b697a). It also fails: alerts fire on the annotated lines 173 and 208 with the standalone comment correctly on 172 and 207. So #80's conclusion stands and now has evidence across two placements rather than one, and no correcting follow-up to #80 is needed. Keep the Path.chmod workaround and name both runs at the call site, so the next reader does not spend a third cycle on a placement variant. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment, not a conclusion
PR #80 concluded that inline CodeQL suppressions are not honoured in this repository. That conclusion is unsupported. The run at
0017b3fplaced the annotation as a trailing same-line comment:CodeQL Python suppression syntax requires a standalone comment line before the alert. One placement was tested and the result was generalised to all placements — the same error shape as concluding a gate is unsatisfiable after missing three of its surfaces (#78).
Caught by an independent cross-family review of the learning-ledger entry that recorded the bad conclusion.
What this tests
The CodeQL check on this PR is the entire result.
Path.chmodcall-shape dependency can be dropped for honestos.chmodplus a stated suppression, and the answer given to the operator ("suppression is not beneficial, it does not work") was wrong.Do not merge on the test suite. 46 tests pass either way; they are not what is being measured.
Verification
python3 -m unittest tests.test_claude_transcript_model— 46 tests, OKcheck_release_consistency.py— OK at 4.6.0 (pre-commit hook)Boundary declaration
Generated and release surfaces
Review and post-condition
Tier 2. Test-only, no production code, no behaviour change.
Post-condition: the CodeQL check conclusion on this PR, which decides whether #80 needs a correcting follow-up.
author: claude
standing_directives: verify a specification before concluding a mechanism is unavailable; test one variable at a time; do not generalise from a single placement; no production scanning coverage reduced
tier: 2
cross_check: PROCEED-WITH-MODIFICATIONS (codex, openai family, direct route, operator-authorized broker bypass, no broker attestation) - round 2 of the ledger review established that the original experiment tested trailing placement while the documented Python syntax requires a standalone line before the alert; this PR is the corrected counterfactual it asked for
post_condition: CodeQL check conclusion on this PR is the load-bearing result; green means #80 needs a correcting follow-up, red means #80 stands with evidence it previously lacked
mcp_coverage_gap: NONE
contributor_rights: OWNER-AUTHORED
operator_reserved: no