Skip to content

Implemented responsive navbar with hamburger menu#14

Open
shubhsahu23 wants to merge 4 commits into
sunilkumar2170:mainfrom
shubhsahu23:responsive-navbar
Open

Implemented responsive navbar with hamburger menu#14
shubhsahu23 wants to merge 4 commits into
sunilkumar2170:mainfrom
shubhsahu23:responsive-navbar

Conversation

@shubhsahu23
Copy link
Copy Markdown

Changes Made

  • Added responsive hamburger menu
  • Added mobile navigation drawer
  • Improved tablet responsiveness
  • Added accessibility attributes
  • Fixed overflow issues

Screenshots

Desktop:
image
image
Mobile:
image
image
Tablet:
image
image

Closes #3

Copilot AI review requested due to automatic review settings May 12, 2026 18:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a responsive top navigation bar that preserves access to key navigation links on mobile/tablet by introducing a hamburger toggle and a collapsible mobile menu, aligning with Issue #3’s accessibility and responsiveness goals.

Changes:

  • Added hamburger toggle state + separate desktop/mobile nav rendering in TopNavBar.
  • Added global overflow-x: hidden to prevent horizontal scrolling.
  • Updated TypeScript config to suppress deprecation warnings; lockfile updated accordingly.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.

File Description
tsconfig.json Adds ignoreDeprecations compiler option.
src/app/globals.css Adds global horizontal overflow suppression on html, body.
src/app/components/TopNavBar.tsx Implements sticky responsive navbar with mobile toggle menu and updated styling/ARIA.
package-lock.json Lockfile metadata updated (adds peer flags on multiple packages).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app/components/TopNavBar.tsx Outdated
Comment thread src/app/components/TopNavBar.tsx
Comment thread src/app/components/TopNavBar.tsx Outdated
Comment thread src/app/globals.css Outdated
@shubhsahu23
Copy link
Copy Markdown
Author

@sunilkumar2170 check this?

@sunilkumar2170
Copy link
Copy Markdown
Owner

Great work on the hamburger menu implementation! 🎉
Please fix these 2 small issues before I merge:

  1. Accessibility Fix (High Priority)
    When mobile menu is closed, links should not be reachable via keyboard or screen readers. Please update like this:
    jsx<nav
    aria-hidden={!isOpen}
    tabIndex={isOpen ? 0 : -1}
    className={...}
  1. overflow-x Fix (Medium Priority)
    Remove overflow-x: hidden from globals.css and apply it only to the specific navbar container instead.
    Fix these 2 things and I'll merge immediately! 💪"

…reen readers; style: scope overflow-x to navbar
@shubhsahu23
Copy link
Copy Markdown
Author

@sunilkumar2170 updated fixed both the issues
1.Accessibility Fix (High Priority)
When mobile menu is closed, links should not be reachable via keyboard or screen readers. Please update like this:
jsx<nav
aria-hidden={!isOpen}
tabIndex={isOpen ? 0 : -1}
className={...}
overflow-x Fix (Medium Priority)
2.Remove overflow-x: hidden from globals.css and apply it only to the specific navbar container instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Responsive Navbar with Hamburger Menu for Mobile & Tablet Devices

3 participants