Fix PDF font fallback crash and escape bullet HTML injection#20
Open
Jaimin2687 wants to merge 1 commit into
Open
Fix PDF font fallback crash and escape bullet HTML injection#20Jaimin2687 wants to merge 1 commit into
Jaimin2687 wants to merge 1 commit into
Conversation
Author
|
Hey @sunilkumar2170 , I just opened this PR patching the PDF.js text-chunking crash and the XSS vulnerability in the contentEditable flow. Because the XSS flaw currently allows arbitrary script injection during resume imports, I strongly recommend prioritizing this review before the GSSoC traffic scales up. Let me know if you need any adjustments to the sanitization logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is submitted as part of GSSoC 2026 contributions.
Issue
Two critical issues were found in the resume import flow:
Crash on missing PDF font objects - commonObjs.get(pdfFontName) can return undefined, then fontObj.name throws during parsing.
XSS risk in bullet editor - bullet strings were injected into a contentEditable HTML string without escaping, allowing HTML/script injection.
What changed
Added a safe fallback when PDF font objects are missing to prevent parser crashes.
Escaped bullet text before converting it to HTML so user input cannot inject HTML.
Testing
npm run test:ci