Skip to content

Fix long unbroken text overflow in resume preview #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jiya3177 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix long unbroken text overflow in resume preview #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/app/components/Resume/ResumePDF/ResumePDFProfile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
ResumePDFLink,
ResumePDFSection,
ResumePDFText,
addSoftBreaksToLongUnbrokenText,
} from "components/Resume/ResumePDF/common";
import type { ResumeProfile } from "lib/redux/types";

Expand Down Expand Up @@ -85,12 +86,17 @@ export const ResumePDFProfile = ({
...styles.flexRow,
alignItems: "center",
gap: spacing["1"],
maxWidth: "100%",
}}
>
<ResumePDFIcon type={iconType} isPDF={isPDF} />
<Wrapper>
<ResumePDFText>{value}</ResumePDFText>
</Wrapper>
<View style={{ flexGrow: 1, flexBasis: 0, maxWidth: "100%" }}>
<Wrapper>
<ResumePDFText>
{addSoftBreaksToLongUnbrokenText(value)}
</ResumePDFText>
</Wrapper>
</View>
</View>
);
})}
Expand Down
20 changes: 19 additions & 1 deletion src/app/components/Resume/ResumePDF/common/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@ import { styles, spacing } from "components/Resume/ResumePDF/styles";
import { DEBUG_RESUME_PDF_FLAG } from "lib/constants";
import { DEFAULT_FONT_COLOR } from "lib/redux/settingsSlice";

const SOFT_BREAK_CHARACTER = "\u200B";
const LONG_UNBROKEN_TEXT_LENGTH = 20;
const SOFT_BREAK_INTERVAL = 8;

export const addSoftBreaksToLongUnbrokenText = (text: string) => {
return text
.split(/(\s+)/)
.map((segment) => {
if (segment.length < LONG_UNBROKEN_TEXT_LENGTH || /\s+/.test(segment)) {
return segment;
}

const chunks = segment.match(new RegExp(`.{1,${SOFT_BREAK_INTERVAL}}`, "g"));
return chunks ? chunks.join(SOFT_BREAK_CHARACTER) : segment;
})
.join("");
};

export const ResumePDFSection = ({
themeColor,
heading,
Expand Down Expand Up @@ -104,7 +122,7 @@ export const ResumePDFBulletList = ({
<ResumePDFText
style={{ lineHeight: "1.3", flexGrow: 1, flexBasis: 0 }}
>
{item}
{addSoftBreaksToLongUnbrokenText(item)}
</ResumePDFText>
</View>
))}
Expand Down