fix(ci): measure only footycollect for coverage (80%) + add tests - #226
Merged
Conversation
added 2 commits
February 19, 2026 17:50
- CI was using --cov without package, so config/ was included and report showed 74% - Use --cov=footycollect to match local and pyproject.toml (footycollect only) - Add tests: factories, management_commands, size_service, core models
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sunr4y
marked this pull request as ready for review
February 19, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI coverage was reporting 74% because it measured the whole project (including
config/). We now measure onlyfootycollect/, matching local runs andpyproject.toml, so the report is ~80%. This PR also adds tests that were in the stash.Changes
--cov=footycollectin the pytest step so coverage is limited tofootycollect/(same as local andinclude = ["footycollect/**"]). Stops counting untestedconfig/(asgi, checks, settings, wsgi, etc.) in the total.footycollect/collection/tests/test_factories.pyfootycollect/collection/tests/test_management_commands.pyfootycollect/collection/tests/test_size_service.pyfootycollect/core/tests/test_models.py