Skip to content

bugfix/SCKT-5_Fix_the_types_of_get_method #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MostafaFawzy7 wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Open

bugfix/SCKT-5_Fix_the_types_of_get_method #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f29042
SCKT-5 | Get Method - Fix types of getAll method
MostafaFawzy7 Mar 20, 2024
a787c3f
SCKT-5 | README.md - Update readme file for `getAll` method
MostafaFawzy7 Mar 20, 2024
eb4bd88
SCKT-5 | GET Method - Revert get Method name
MostafaFawzy7 Mar 20, 2024
800dc87
SCKT-5 | DELETE Method - Remove modal type from returned value of del…
MostafaFawzy7 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ interface User {
email: string;
}

ApiKitClient.get<User[]>('/users')
ApiKitClient.get<User>('/users')
.then(response => console.log(response.data)) // Expected to be of type User[]
.catch(error => console.error(error));
```
Expand Down
6 changes: 3 additions & 3 deletions src/ApiKitClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ export class ApiKitClient {
}
}

public static async get<T>(endpoint: string, params?: URLSearchParams): Promise<AxiosResponse<T>> {
public static async get<T>(endpoint: string, params?: URLSearchParams): Promise<AxiosResponse<T[]>> {
this.checkInitialization();
return this.instance!.get<T>(endpoint, { params });
return this.instance!.get<T[]>(endpoint, { params });
}

public static async getOne<T>(endpoint: string, params?: URLSearchParams): Promise<AxiosResponse<T>> {
Expand Down Expand Up @@ -71,7 +71,7 @@ export class ApiKitClient {
return this.instance!.patch<T>(endpoint, data);
}

public static async delete<T>(endpoint: string): Promise<AxiosResponse<T>> {
public static async delete<T>(endpoint: string): Promise<AxiosResponse> {
this.checkInitialization();
return this.instance!.delete<T>(endpoint);
}
Expand Down