fix: treat an empty TransformOptions as no transform, not a render request - #55
Merged
Conversation
…quest GetPublicUrl, Download and CreateSignedUrl selected the image-render endpoint whenever transform options were non-null. But TransformOptions ships non-null defaults (Resize=Cover, Quality=80, Format=origin), so a fresh `new TransformOptions()` is never empty and always emits resize/quality — routing "no transform" calls to `/render/image/...?format=origin&resize=cover&quality=80`. That URL is broken locally (imgproxy off) and silently transforms in production. Add TransformOptions.IsEmpty (every field still at its constructed default) and select the render endpoint only when a transform is actually requested, mirroring the storage-js `wantsTransformation` guard. Also skips the transform query on the download paths so an empty options object never dangles resize/quality onto an object URL. Fixes #37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37