feat: classify oversized-upload 413s - #56
Merged
Merged
Conversation
A storage request rejected for exceeding the gateway's request-size limit surfaced correctly as a SupabaseStorageException but was left Reason.Unknown, with no hint at a way forward. Add FailureHint.Reason.EntityTooLarge and map HTTP 413 to it, with the enum value's doc and <remarks> on both Upload overloads pointing callers at the resumable UploadOrResume. Cover it with a unit test (413 => EntityTooLarge) and a contract test asserting an oversized upload against a 413 text/html body surfaces StatusCode 413 / EntityTooLarge rather than crashing JSON parsing. Also completes the XML documentation for the FailureHint type, clearing its CS1591 debt. Relates to #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A storage request rejected for exceeding the gateway's request-size limit surfaced correctly as a SupabaseStorageException but was left Reason.Unknown, with no hint at a way forward.
Add FailureHint.Reason.EntityTooLarge and map HTTP 413 to it, with the enum value's doc and on both Upload overloads pointing callers at the resumable UploadOrResume. Cover it with a unit test (413 => EntityTooLarge) and a contract test asserting an oversized upload against a 413 text/html body surfaces StatusCode 413 / EntityTooLarge rather than crashing JSON parsing. Also completes the XML documentation for the FailureHint type, clearing its CS1591 debt.
Relates to #14