Skip to content

fix(otp): improve error messages when phone provider is not configured #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Suryap-hub wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −3
Open

fix(otp): improve error messages when phone provider is not configured #2599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions internal/api/otp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,12 @@ func (a *API) Otp(w http.ResponseWriter, r *http.Request) error {
return a.SmsOtp(w, r)
}

return apierrors.NewBadRequestError(apierrors.ErrorCodeValidationFailed, "One of email or phone must be set")
return apierrors.NewBadRequestError(
apierrors.ErrorCodeValidationFailed,
"One of 'email' or 'phone' must be provided in the request body. "+
"If you are using email OTP, ensure the 'email' field is set. "+
"If you are using SMS OTP, ensure the 'phone' field is set in E.164 format (e.g. +19998887777).",
)
}

type SmsOtpResponse struct {
Expand All @@ -105,8 +110,13 @@ func (a *API) SmsOtp(w http.ResponseWriter, r *http.Request) error {
config := a.config

if !config.External.Phone.Enabled {
return apierrors.NewBadRequestError(apierrors.ErrorCodePhoneProviderDisabled, "Unsupported phone provider")
}
return apierrors.NewBadRequestError(
apierrors.ErrorCodePhoneProviderDisabled,
"SMS/phone authentication is not enabled for this project. "+
"To fix this, go to your Supabase Dashboard → Authentication → Providers → Phone, "+
"enable Phone Auth, and configure a provider such as Twilio or Vonage.",
)
}
var err error

params := &SmsParams{}
Expand Down