-
Notifications
You must be signed in to change notification settings - Fork 12
Add supabase/mcp as a pinned submodule + SUPABASE_MCP_SERVER_PATH local-build override #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9235091
evals-mcp-local-build-override
90aeb81
add supabase/mcp as a pinned submodule at submodules/mcp
barryroodt 7d2e7f6
README: document evaling an exact MCP revision via the pinned submodule
barryroodt 3fd0aa7
fix: expose the local MCP server build to containerized agents
barryroodt 2ad5b5b
fix: realpath the local MCP override once, deriving command and mount…
barryroodt 3809755
perf: memoize the local MCP override resolution (Pedro's nit)
barryroodt 647cf0d
chore: merge main (repo-wide biome formatting)
barryroodt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| [submodule "submodules/agent-skills"] | ||
| path = submodules/agent-skills | ||
| url = git@github.com:supabase/agent-skills.git | ||
| [submodule "submodules/mcp"] | ||
| path = submodules/mcp | ||
| url = git@github.com:supabase/mcp.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this re-runs
resolveLocalMcpServer()+ anothergitToplevel(), on top of the calls already made increateConfig, so a fewgitspawns per eval run, and it fires even in local-stack mode where the mount is unused.Could memoize the resolution. Totally minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixed, in 3809755. The whole resolution (entry, base dir, mount root) is now computed once and memoized on the raw env value, so the git spawns happen once per run regardless of how many times the config or the mounts ask, including local-stack runs. Kept the not-found error path uncached on purpose: if you build the server after a failed attempt, the retry should see it. Thanks for the careful pass! 🙏