-
Notifications
You must be signed in to change notification settings - Fork 12
platform-lite: serve the ClickHouse logs endpoint (/analytics/endpoints/logs) #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barryroodt
wants to merge
19
commits into
main
Choose a base branch
from
platform-lite-clickhouse-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
dcf6935
platform-lite: serve the ClickHouse logs endpoint (/analytics/endpoin…
barryroodt 15af251
platform-lite: ClickHouse toIntOrZero family for query_logs SQL
barryroodt c60adeb
platform-lite: polymorphic toString for ClickHouse-dialect logs SQL
barryroodt 2e3d2b3
platform-lite: document the deliberate ClickHouse-compat surface + ti…
barryroodt d548d65
platform-lite: route-level tests for the logs read-only guarantee
barryroodt a0305f8
platform-lite: document provenance of the hand-modeled ClickHouse sur…
barryroodt 694bcc0
platform-lite: correct provenance conflation + logsServiceSchema drif…
barryroodt 8f71f95
platform-lite: drop the logsServiceSchema tripwire, keep corrected pr…
barryroodt 32f9ce2
platform-lite: cite both platform PRs, note in-review status
barryroodt a52cfab
platform-lite: separate per-PR platform capabilities in provenance
barryroodt 864f488
platform-lite: disambiguate current-main vs mcp#333 in the view header
barryroodt b759ca2
platform-lite: review fixes — {message} on 400, pin CTE status, reloc…
barryroodt 51dcf92
platform-lite: hosted-faithful map values + review minors
barryroodt 89b814d
platform-lite: close out review minors properly
barryroodt 36e6357
platform-lite: seed storage logs; reject unknown seed sources loudly
barryroodt c3dfccf
platform-lite: expose only the unified logs stream; String-only OrZer…
barryroodt 8cc63e4
chore: merge main (repo-wide biome formatting)
barryroodt 7d84ccf
platform-lite: fix logs fixture divergences found in review
barryroodt d0c6b81
platform-lite: fire the wall-clock guard only on logs-reading SQL
barryroodt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KNOWN LIMITATION note covers the query params, but the same time-semantics hole is reachable through the SQL itself, where it fails silently instead of loudly.
For example, seeds carry fixed past dates while
now()is real wall-clock, soselect count(*) from logs where source = 'edge_logs' and timestamp > now() - interval '24 hours'returns200 {result: []}with no error, and the agent concludes "no errors occurred".Until relative-time seeding lands, a guard that rejects
now()/current_timestampin logs SQL (loud, like the other guards) would keep evals honest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed,
timestamp > now() - interval '24 hours'returns200 {result: []}. Wall-clock functions now reject loudly (7d84ccf), but only when the statement readslogs, so thenow()orientation probes your #333 A/B saw still pass (d0c6b81).