test(pg-delta): add PG15+ roundtrip coverage for NULLS NOT DISTINCT unique indexes#185
Open
test(pg-delta): add PG15+ roundtrip coverage for NULLS NOT DISTINCT unique indexes#185
NULLS NOT DISTINCT unique indexes#185Conversation
|
Agent-Logs-Url: https://github.com/supabase/pg-toolbelt/sessions/58410997-9312-46f5-bfe5-fa424fb0805c Co-authored-by: avallete <8771783+avallete@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add integration tests for unique indexes with nulls not distinct
test(pg-delta): add PG15+ roundtrip coverage for Apr 10, 2026
NULLS NOT DISTINCT unique indexes
commit: |
avallete
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 15+ unique indexes can use
NULLS NOT DISTINCT, which changes duplicate-NULLsemantics. pg-delta already models and serializes this attribute, but it lacked end-to-end integration coverage to prove the clause survives extract → diff → apply → re-read roundtrips and directional toggles.Added PG15+ roundtrip coverage
NULLS NOT DISTINCTAdded directional toggle coverage
NULLS NOT DISTINCTNULLS NOT DISTINCTunique index → plain unique indexMade clause loss fail loudly
Scope
Example covered by the new tests: