fix(pg-delta): drop out of order operations

[avallete]

I dug into the reported DROP-ordering regressions and reproduced both cases with focused integration tests before changing sorter behavior.

Context

There were two concrete failures in generated plan SQL:

1. FK-related table drops were ordered as:

   • DROP TABLE challenge_levels
   • DROP TABLE user_challenge_progress

   That fails because the FK on user_challenge_progress still depends on challenge_levels.

2. Publication membership changes were ordered as:

   • DROP TABLE challenge_levels
   • ALTER PUBLICATION pub DROP TABLE challenge_levels

   That fails because the table must still exist when removing it from the publication.

Root Cause

The interesting part is that the catalog dependency extraction was already capturing the important relationships:

• FK dependencies exist at the constraint level
• publication-to-table dependencies already exist in the dependency data

The actual gap was in the change metadata that feeds the sorter:

• DropTable only exposed table and column stable IDs, so FK edges that only existed at the constraint level were not influencing whole-table drop ordering.
• AlterPublicationDropTables exposed requires, but not drops, so it was treated like a non-destructive ALTER and sorted after the real table drop.

Fix

This patch fixes the ordering by making the destructive changes advertise the right stable IDs to the sorter:

• DropTable now includes table constraint stable IDs in its drop-phase metadata, which lets FK constraint dependencies affect whole-table drop ordering.
• AlterPublicationDropTables now exposes dropped table stable IDs, so it participates in the destructive/drop phase and runs before DROP TABLE.

I also added focused integration coverage for both reported scenarios, plus a small unit assertion around the publication change metadata.

Verification

Verified with:

• PGDELTA_TEST_POSTGRES_VERSIONS=17 bun run test tests/integration/fk-constraint-ordering.test.ts
• PGDELTA_TEST_POSTGRES_VERSIONS=17 bun run test tests/integration/publication-operations.test.ts
• PGDELTA_TEST_POSTGRES_VERSIONS=17 bun run test tests/integration/trigger-operations.test.ts
• bun run test src/core/objects/publication/changes/publication.alter.test.ts
• bun run test src/core/objects/table/changes/table.drop.test.ts

So this ends up being less about missing raw dependency extraction and more about making sure destructive change objects surface enough information for the sorter to use the dependency graph correctly.

Fixes #193

[changeset-bot]

🦋 Changeset detected

Latest commit: c9b4f6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@supabase/pg-delta	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/supabase/pg-toolbelt/@supabase/pg-delta@192

npm i https://pkg.pr.new/supabase/pg-toolbelt/@supabase/pg-topo@192

commit: c9b4f6f

[jgoux]

Great work on this!