fix: add lifecycle logs for empty bucket operations#1016
Open
fix: add lifecycle logs for empty bucket operations#1016
Conversation
itslenny
force-pushed
the
lenny/fix-add-empty-bucket-lifecycle-logs
branch
from
9720478 to
fcf131e
Compare
TylerHillery
approved these changes
Apr 13, 2026
ferhatelmas
reviewed
Apr 13, 2026
|
|
||
| await backend.deleteObjects(storageS3Bucket, prefixes) | ||
|
|
||
| await Promise.allSettled( |
Member
There was a problem hiding this comment.
can we add a test to ensure event is triggerred to prevent regressions?
Coverage Report for CI Build 24355971583Coverage increased (+0.02%) to 80.997%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
itslenny
force-pushed
the
lenny/fix-add-empty-bucket-lifecycle-logs
branch
from
ff2ca2f to
be116a3
Compare
itslenny
force-pushed
the
lenny/fix-add-empty-bucket-lifecycle-logs
branch
from
be116a3 to
18024f2
Compare
ferhatelmas
reviewed
Apr 13, 2026
| }) | ||
|
|
||
| it('will emit webhooks for each deleted object during empty bucket operation', async () => { | ||
| const emptyTestBucketName = 'bucket-empty-webhook-test' |
Member
There was a problem hiding this comment.
might be better to make it unique as well
ferhatelmas
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
There are no lifecycle logs emitted when emptying buckets
What is the new behavior?
Emit delete object lifecycle logs for all objects removed when a bucket is emptied