fix(storage): use exc.response.text instead of resp.text in error handling - #1568
Open
Samearth17 wants to merge 1 commit into
Open
fix(storage): use exc.response.text instead of resp.text in error handling#1568Samearth17 wants to merge 1 commit into
Samearth17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When an HTTP error occurs in the storage API and the response body cannot be parsed into the expected JSON keys (
message,error,statusCode), aKeyErroris caught. However, the fallback error message attempts to accessresp.text. Becauserespis the result ofexc.response.json()(a Python dictionary), dictionaries do not have a.textattribute. This triggers anAttributeErrorthat completely hides the original API/storage error from the user.Issue: #1563
What is the new behavior?
This PR updates the error handler to correctly reference
exc.response.text(the rawhttpxresponse object) instead ofresp.text. This ensures that when JSON parsing fails, the raw text of the HTTP error is properly surfaced to the developer.I applied this fix to both
AsyncBucketActionsMixinandSyncBucketActionsMixin.Additional context
None