Skip to content

fix AY freq-to-tone calculation #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahihi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix AY freq-to-tone calculation #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions source/AYUGens/sc/AY.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ AY : UGen {

*categories { ^ #["UGens>Oscillators"] }

*freqtotone { |freq|
// Approximate empirical...
//^(109300 / (freq - 3.70727))
^(110300 / (freq - 0.5))
*freqtotone { |freq, sampleRate|
var chipTactsPerOutCount;
sampleRate = sampleRate ?? { Server.default.sampleRate };
// this mirrors ayemu's internal calculation of ChipTacts_per_outcount
chipTactsPerOutCount = 1773400.div(sampleRate).div(8);
^(sampleRate * chipTactsPerOutCount / (2 * freq)).round
}
}
6 changes: 6 additions & 0 deletions source/AYUGens/sc/HelpSource/Classes/AY.schelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ general add controls for the resulting signal
METHOD::freqtotone
converts a frequency value to something appropriate for the strong::tonea::, strong::toneb:: and strong::tonec:: inputs.

ARGUMENT::freq
the frequency value in Hertz.

ARGUMENT::sampleRate
sample rate for the frequency conversion. default is strong::Server.default.sampleRate::.

EXAMPLES::

CODE::
Expand Down
Loading