housekeeper: unexport in-file-only BinaryNotice component#148
Open
stonexer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
exportkeyword fromBinaryNoticeinpackages/server/src/components/artifactView.tsx. It stays a plain module-local function - no behavior change.Why
BinaryNoticeis a private presentational subcomponent rendered only withinartifactView.tsx(3 in-file call sites). Nothing imports it, so theexportleaked accidental module surface - the same class of cleanup as #146 (fmtBytes). Unlike a design-token/lib symbol, a component-local render helper has no public-API rationale to be exported.Evidence
rg '\bBinaryNotice\b'matches onlyartifactView.tsx(declaration + 3 uses); zero references in the daemon package or tests.artifactView(rg "export .* from .*artifactView"empty).Checks
pnpm -r typecheckgreen (server + daemon)pnpm --filter @loopany/server testgreen (645 passed, 3 skipped)